-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port grid_map_costmap_2d to ros2 #240
Conversation
Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
@SteveMacenski @Marwan99 need to add |
How about using the |
I think the best answer is to add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything to mention. Is there anything you want to highlight that you had to change by hand that might be worth specifically having me check?
grid_map_costmap_2d/include/grid_map_costmap_2d/grid_map_costmap_2d.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
…dencies Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
I don't think anything needs to be looked over too much. There was a rostest which needed some work since I had to convert it to a normal gtest, it barely involved any launch stuff. Otherwise everything is pretty standard. I need some help with the Circle CI config though, there are a couple of errors I can't figure out. Would be great if you could have a look. |
You didn't install the dependencies with rosdep for the underlay workspace. |
e3af928
to
a849caa
Compare
All of my commits named that never work now :-) * force push * you never saw it... |
Haha, okay didn't work 😆 I'm not sure where it's going wrong. |
try the -r flag |
Does the |
Yes, that is a good catch |
Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
@SteveMacenski @maximilianwulf ready to merge! |
Signed-off-by: Sarthak Mittal sarthakmittal2608@gmail.com